Add ability to reuse trigger in different templates; #285
Conversation
|
@Antondomashnev This is amazing stuff, thanks so much! 👍 It actually fixes a long standing task: #167 Let me give this a try and I'll report with comments later. Regarding pre-defined triggers that would ship with Buildasaur, I think that's a great idea, but please create a separate issue for that and put your thoughts there, to keep these two issues separate. Thanks! 😊 |
|
|
||
| super.prepareForSegue(segue, sender: sender) | ||
| } | ||
|
|
||
| @IBAction func addTriggerButtonClicked(sender: AnyObject) { | ||
| self.editTrigger(nil) | ||
| let buttons = ["Add new", "Add existed", "Cancel"] |
There was a problem hiding this comment.
Can we please rename that to Add existing?
|
@czechboy0 thanks for the feedback, these comments are fixed and the PR ready to be merged 🚀 |
|
Hi @czechboy0 any news when it can be merged, can I help to speed up the process somehow? Thanks |
|
Hey, apologies I'm at a vacation at the moment, so I haven't yet had a chance to test it locally. Should be able to merge after testing in about a week, thanks for your work on this! :) |
|
Ah, then it's my apologies, sorry for interrupting, have a good holiday =) |
|
Ok, I'm back from vacation now :) I checked out the code, looks great, thanks so much! 😊 Just one little thing: the layout seems to be slightly off on the build template screen, see screenshots before and after (the plus button for adding a trigger has been shifted down which offsets the whole window's layout to the point that the top and bottom content is getting clipped). Original: Changed: So if you could just fix that I'll be happy to merge this. |
|
@czechboy0 thanks to pointing it out, I'll definitely update the PR with fix soon =) |
|
@czechboy0 done =) |
|
Great, thanks! 👍 |
Hi All,
First of all thanks for the great tool @czechboy0, it really rocks!
In my current setup, I have four syncers that are using two same triggers. And to create those triggers I had to write same things four times, to improve the UX for that kind of setup I would like to introduce the screen to select trigger from already created triggers list.
Thit PR makes following changes:
+button to add a trigger to the template the alert will appear with an option to select from already existed or create a new oneAdd existednew screen will appear with the list of all available triggersdeletebutton only removes the trigger from the table view but not from the database.Looking forward to hearing your thoughts.
P.S. also have the following idea to have predefined triggers already in Builda, so user doesn't have to type run script for CocoaPods or etc.